Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883253002: Load API call data from function instead of embedding it in handler. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Load API call data from function instead of embedding it in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/23866a6f99d20e815f289358570607f1c6b20086 Cr-Commit-Position: refs/heads/master@{#26326}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix arm64 #

Patch Set 5 : Fix mips #

Total comments: 2

Patch Set 6 : Rename scratch_in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -89 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 4 5 2 chunks +14 lines, -17 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 3 4 2 chunks +8 lines, -10 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 3 4 5 2 chunks +14 lines, -16 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 2 3 4 5 2 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 10 months ago (2015-01-29 12:37:47 UTC) #2
dcarney
lgtm https://codereview.chromium.org/883253002/diff/80001/src/ic/x64/handler-compiler-x64.cc File src/ic/x64/handler-compiler-x64.cc (right): https://codereview.chromium.org/883253002/diff/80001/src/ic/x64/handler-compiler-x64.cc#newcode132 src/ic/x64/handler-compiler-x64.cc:132: MacroAssembler* masm, const CallOptimization& optimization, can you just ...
5 years, 10 months ago (2015-01-29 13:24:33 UTC) #3
ulan
https://codereview.chromium.org/883253002/diff/80001/src/ic/x64/handler-compiler-x64.cc File src/ic/x64/handler-compiler-x64.cc (right): https://codereview.chromium.org/883253002/diff/80001/src/ic/x64/handler-compiler-x64.cc#newcode132 src/ic/x64/handler-compiler-x64.cc:132: MacroAssembler* masm, const CallOptimization& optimization, On 2015/01/29 13:24:33, dcarney ...
5 years, 10 months ago (2015-01-29 14:55:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883253002/100001
5 years, 10 months ago (2015-01-29 14:56:36 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-01-29 15:26:33 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 15:26:51 UTC) #8
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/23866a6f99d20e815f289358570607f1c6b20086
Cr-Commit-Position: refs/heads/master@{#26326}

Powered by Google App Engine
This is Rietveld 408576698