Issue 883213003: Remove build dependencies on base.gyp:* and sdch.gyp:* from 'all'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 883213003: Remove build dependencies on base.gyp:* and sdch.gyp:* from 'all'. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke

Modified:
5 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove build dependencies on base.gyp:* and sdch.gyp:* from 'all'. This CL changes the sdch.gyp dependency to be explicitly 'sdch.gyp:sdch' (since there is only one target in the file), and adds a new 'base_all' target in base.gyp. This changes is needed for the GN migration, since GN doesn't support wildcards. R=brettw@chromium.org BUG=451558

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -1 line)			Patch
	M	base/base.gyp	View		1 chunk	+66 lines, -0 lines	0 comments	Download
	M	build/all.gyp	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/883213003/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/883213003/diff/1/build/all.gyp#newcode18 build/all.gyp:18: '../base/base.gyp:*', Did you mean to update this line?

5 years, 10 months ago (2015-01-30 18:44:59 UTC) #2

Dirk Pranke

I'm not sure if I'm gonna land this yet, by the way ... based on ...

5 years, 10 months ago (2015-01-30 18:46:50 UTC) #3

Message was sent while issue was closed.

Closing, as I'm abandoning this for now ...

Expand Messages | Collapse Messages