Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 883203003: SampleApp documentation (Closed)

Created:
5 years, 10 months ago by herb_g
Modified:
5 years, 10 months ago
Reviewers:
hcm, jcgregorio
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add some content. #

Patch Set 3 : First Draft #

Patch Set 4 : Fix spacing #

Total comments: 4

Patch Set 5 : Make changes from review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A site/user/sample/sampleapp.md View 1 2 3 4 1 chunk +30 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (3 generated)
herb_g
5 years, 10 months ago (2015-01-29 19:04:00 UTC) #2
jcgregorio
https://codereview.chromium.org/883203003/diff/60001/site/user/sample/sampleapp.md File site/user/sample/sampleapp.md (right): https://codereview.chromium.org/883203003/diff/60001/site/user/sample/sampleapp.md#newcode15 site/user/sample/sampleapp.md:15: You can find how to build the SampleApp for ...
5 years, 10 months ago (2015-01-29 19:10:17 UTC) #4
hcm
Thanks for doing this, one other small thing from me, otherwise looks good https://codereview.chromium.org/883203003/diff/60001/site/user/sample/sampleapp.md File ...
5 years, 10 months ago (2015-01-29 20:14:18 UTC) #5
herb_g
Address comments. PTAL https://codereview.chromium.org/883203003/diff/60001/site/user/sample/sampleapp.md File site/user/sample/sampleapp.md (right): https://codereview.chromium.org/883203003/diff/60001/site/user/sample/sampleapp.md#newcode1 site/user/sample/sampleapp.md:1: About the SampleApp On 2015/01/29 20:14:18, ...
5 years, 10 months ago (2015-01-30 02:24:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883203003/80001
5 years, 10 months ago (2015-01-30 02:25:20 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 02:25:21 UTC) #9
hcm
On 2015/01/30 02:25:21, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 10 months ago (2015-01-30 04:29:19 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/e4e01b8608cd7aeaf47c914ddfb2afa3239a0bc6
5 years, 10 months ago (2015-01-30 04:31:08 UTC) #11
tfarina
5 years, 10 months ago (2015-01-30 14:33:43 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/883203003/diff/80001/site/user/sample/samplea...
File site/user/sample/sampleapp.md (right):

https://codereview.chromium.org/883203003/diff/80001/site/user/sample/samplea...
site/user/sample/sampleapp.md:3: The SampleApp displays a series of slides that
exhibit specific features of the Skia system. It is mainly controlled using the
keyboard: left (←) and (→) right arrows to move from slide to
slide. Some slides require use resources stored outside the program. These
resources are stored in the `<skia-path>/resources` directory.
nit: require use?

https://codereview.chromium.org/883203003/diff/80001/site/user/sample/samplea...
site/user/sample/sampleapp.md:13: * Display and manipulate your own pictures -
use the `--picture <skp-file-path>.skp` to use the `.skp` file as the slide
desplayed by SampleApp. A `.skp` file can be generated by...
generated by...? Explain how to generate it or just point to another doc that
explains it? Otherwise just remove this sentence?

Powered by Google App Engine
This is Rietveld 408576698