Load web contents after tab is created.

Load web contents after tab is created.

In document mode, we used to start loading the web contents of a newly
opened tab before the chrome tab object is ready. This would result in
chrome intercept delegate not being initialized in time to figure out
whether the loaded URL needs to be sent as an intent instead.

This changes the order of operations to create the chrome tab first with
the given web contents and only then initiate the load.

BUG=432562
Committed: https://crrev.com/4c55f398def3214369aefa9f2f2e8f5940d3799d
Cr-Commit-Position: refs/heads/master@{#313966}

[Maria, 2015-01-29 02:15:49]

mariakhomenko@chromium.org changed reviewers:
+ dfalcantara@chromium.org, tedchoc@chromium.org

[Maria, 2015-01-29 02:15:50]

Looking for comments regarding the approach. There's still a known issue where
we don't correctly close the newly opened tab with the URL after firing the
intent and I am working to fix it.

[gone, 2015-01-29 03:11:33]

lgtm on my end. Would wait for Ted's input, though.

https://codereview.chromium.org/883153002/diff/1/chrome/browser/android/chrom...
File chrome/browser/android/chrome_web_contents_delegate_android.cc (right):

https://codereview.chromium.org/883153002/diff/1/chrome/browser/android/chrom...
chrome/browser/android/chrome_web_contents_delegate_android.cc:355: }
Add a default: here.  Also, man this switch hurts my head to read.

[Ted C, 2015-01-29 21:38:11]

lgtm w/ a bit of name massaging

https://codereview.chromium.org/883153002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_android.cc (right):

https://codereview.chromium.org/883153002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_android.cc:492: true /*
is_renderer_initiated */);
this seems a bit odd to me...to have something that is explicitly called from
the browser but marks it as started from the renderer.

I think we either should name this to be clearer or pass along this bit from
elsewhere.

[Maria, 2015-01-29 21:53:04]

Uploaded a new patch without the switch statement and with is_renderer_initiated
passed as a parameter.

[Maria, 2015-01-29 23:11:02]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2015-01-29 23:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/883153002/20001

[commit-bot: I haz the power, 2015-01-29 23:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 23:18:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Maria, 2015-01-29 23:30:48]

mariakhomenko@chromium.org changed reviewers:
+ sky@chromium.org

[Maria, 2015-01-29 23:30:49]

Scott, can you please approve for chrome.gyp OWNERS?

[sky, 2015-01-29 23:47:34]

LGTM

[Maria, 2015-01-30 01:21:33]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2015-01-30 01:22:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/883153002/20001

[commit-bot: I haz the power, 2015-01-30 01:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 01:30:30]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Maria, 2015-01-30 01:47:13]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2015-01-30 01:48:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/883153002/40001

[commit-bot: I haz the power, 2015-01-30 02:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 02:40:44]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Maria, 2015-01-30 18:56:53]

mariakhomenko@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Maria, 2015-01-30 18:56:54]

John, 

I had to add another findbugs exception for a field used downstream, pending
further upstreaming of that code. Need OWNERS approval. Thanks.

[jbudorick, 2015-01-30 18:58:11]

rslgtm for build/android/

[jbudorick, 2015-01-30 18:58:18]

On 2015/01/30 18:58:11, jbudorick wrote:
> rslgtm for build/android/

lgtm

[Maria, 2015-01-30 18:59:50]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2015-01-30 19:00:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/883153002/60001

[commit-bot: I haz the power, 2015-01-30 20:01:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-30 20:03:05]

Patchset 4 (id:??) landed as
https://crrev.com/4c55f398def3214369aefa9f2f2e8f5940d3799d
Cr-Commit-Position: refs/heads/master@{#313966}