Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2601)

Unified Diff: ipc/ipc_platform_file_attachment_posix.cc

Issue 883093003: IPC::Message Refactoring: Move POSIX specific bits to PlatformFileAttachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing Windows build error Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_platform_file_attachment_posix.h ('k') | ipc/mojo/ipc_channel_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_platform_file_attachment_posix.cc
diff --git a/ipc/ipc_platform_file_attachment.cc b/ipc/ipc_platform_file_attachment_posix.cc
similarity index 71%
rename from ipc/ipc_platform_file_attachment.cc
rename to ipc/ipc_platform_file_attachment_posix.cc
index 5430c6de6734ae29e8477d0b3964d0c8d83a66b5..b704750c15625cf2ce1889f3d51b48f42acaf81d 100644
--- a/ipc/ipc_platform_file_attachment.cc
+++ b/ipc/ipc_platform_file_attachment_posix.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ipc/ipc_platform_file_attachment.h"
+#include "ipc/ipc_platform_file_attachment_posix.h"
namespace IPC {
namespace internal {
@@ -11,6 +11,10 @@ PlatformFileAttachment::PlatformFileAttachment(base::PlatformFile file)
: file_(file) {
}
+PlatformFileAttachment::PlatformFileAttachment(base::ScopedFD file)
+ : file_(file.get()), owning_(file.Pass()) {
+}
+
PlatformFileAttachment::~PlatformFileAttachment() {
}
@@ -18,6 +22,11 @@ MessageAttachment::Type PlatformFileAttachment::GetType() const {
return TYPE_PLATFORM_FILE;
}
+base::PlatformFile PlatformFileAttachment::TakePlatformFile() {
+ ignore_result(owning_.release());
+ return file_;
+}
+
base::PlatformFile GetPlatformFile(
scoped_refptr<MessageAttachment> attachment) {
DCHECK_EQ(attachment->GetType(), MessageAttachment::TYPE_PLATFORM_FILE);
« no previous file with comments | « ipc/ipc_platform_file_attachment_posix.h ('k') | ipc/mojo/ipc_channel_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698