IPC::Message Refactoring: Move POSIX specific bits to PlatformFileAttachment

ipc/ipc_message.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message.h"
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
 #include "build/build_config.h"
+#include "ipc/ipc_message_attachment.h"
 #include "ipc/ipc_message_attachment_set.h"
 
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
+#include "ipc/ipc_platform_file_attachment_posix.h"
 #endif
 
 namespace {
 
 base::StaticAtomicSequenceNumber g_ref_num;
 
 // Create a reference number for identifying IPC messages in traces. The return
 // values has the reference number stored in the upper 24 bits, leaving the low
 // 8 bits set to 0 for use as flags.
 inline uint32 GetRefNumUpper24() {
@@ skipping 96 matching lines @@
   const char* data = end_of_payload();
   data -= sizeof(int64);
   return *(reinterpret_cast<const int64*>(data));
 }
 
 void Message::set_received_time(int64 time) const {
   received_time_ = time;
 }
 #endif
 
-#if defined(OS_POSIX)
-bool Message::WriteFile(base::ScopedFD descriptor) {
+bool Message::WriteAttachment(scoped_refptr<MessageAttachment> attachment) {
   // We write the index of the descriptor so that we don't have to
   // keep the current descriptor as extra decoding state when deserialising.
   WriteInt(attachment_set()->size());
-  return attachment_set()->AddToOwn(descriptor.Pass());
+  return attachment_set()->AddAttachment(attachment);
 }
 
-bool Message::WriteBorrowingFile(const base::PlatformFile& descriptor) {
-  // We write the index of the descriptor so that we don't have to
-  // keep the current descriptor as extra decoding state when deserialising.
-  WriteInt(attachment_set()->size());
-  return attachment_set()->AddToBorrow(descriptor);
-}
-
-bool Message::ReadFile(PickleIterator* iter, base::ScopedFD* descriptor) const {
+bool Message::ReadAttachment(
+    PickleIterator* iter,
+    scoped_refptr<MessageAttachment>* attachment) const {
   int descriptor_index;
   if (!iter->ReadInt(&descriptor_index))
     return false;
 
   MessageAttachmentSet* attachment_set = attachment_set_.get();
   if (!attachment_set)
     return false;
 
-  base::PlatformFile file = attachment_set->TakeDescriptorAt(descriptor_index);
-  if (file < 0)
-    return false;
-
-  descriptor->reset(file);
-  return true;
+  *attachment = attachment_set->GetAttachmentAt(descriptor_index);
+  return nullptr != attachment->get();
 }
 
-bool Message::HasFileDescriptors() const {
+bool Message::HasAttachments() const {
   return attachment_set_.get() && !attachment_set_->empty();
 }
 
-#endif
-
 }  // namespace IPC