chrome/test/chromedriver/chrome/web_view_impl.h - Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.h

Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing scoping bug; switching throughput and latency fields to doubles Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/network_conditions_override_manager.cc ('K') | « chrome/test/chromedriver/chrome/web_view.h ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/web_view_impl.h

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.h b/chrome/test/chromedriver/chrome/web_view_impl.h

index 19660dce363bb10f4cf39aac6109dd5bf6556df2..9fcadaf15fb5a5ef64c5b92f8aa6af92b26e6c75 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.h

+++ b/chrome/test/chromedriver/chrome/web_view_impl.h

@@ -27,6 +27,7 @@ class DomTracker;

class FrameTracker;

class GeolocationOverrideManager;

class MobileEmulationOverrideManager;

+class NetworkConditionsOverrideManager;

class HeapSnapshotTaker;

struct KeyEvent;

struct MouseEvent;

@@ -87,6 +88,8 @@ class WebViewImpl : public WebView {

bool* is_pending) override;

JavaScriptDialogManager* GetJavaScriptDialogManager() override;

Status OverrideGeolocation(const Geoposition& geoposition) override;

+ Status OverrideNetworkConditions(

+ const NetworkConditions& network_conditions) override;

Status CaptureScreenshot(std::string* screenshot) override;

Status SetFileInputFiles(const std::string& frame,

const base::DictionaryValue& element,

@@ -117,6 +120,8 @@ class WebViewImpl : public WebView {

scoped_ptr<JavaScriptDialogManager> dialog_manager_;

scoped_ptr<MobileEmulationOverrideManager> mobile_emulation_override_manager_;

scoped_ptr<GeolocationOverrideManager> geolocation_override_manager_;

+ scoped_ptr<NetworkConditionsOverrideManager>

+ network_conditions_override_manager_;

scoped_ptr<HeapSnapshotTaker> heap_snapshot_taker_;

scoped_ptr<DebuggerTracker> debugger_;

scoped_ptr<DevToolsClient> client_;