chrome/test/chromedriver/server/http_handler.cc - Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Working implementation of emulating network conditions with chromedriver Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/client/chromedriver.py ('K') | « chrome/test/chromedriver/client/command_executor.py ('k') | chrome/test/chromedriver/session.h » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 6e452fe8795f80769cc8f73d869319de6aa6e5af..00069aeb62fa3399a76d4740b1824db342f01372 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -370,6 +370,16 @@ HttpHandler::HttpHandler(

kPost,

"session/:sessionId/location",

WrapToCommand("SetGeolocation", base::Bind(&ExecuteSetLocation))),

+ CommandMapping(

+ kGet,

+ "session/:sessionId/network_conditions",

samuong 2015/02/11 23:22:14 Let's put this behind a vendor-specific URL (see h

srawlins 2015/02/25 22:40:57 Done.

+ WrapToCommand("GetNetworkConditions",

+ base::Bind(&ExecuteGetNetworkConditions))),

+ CommandMapping(

+ kPost,

+ "session/:sessionId/network_conditions",

+ WrapToCommand("SetNetworkConditions",

+ base::Bind(&ExecuteSetNetworkConditions))),

CommandMapping(kGet,

"session/:sessionId/application_cache/status",

base::Bind(&ExecuteGetStatus)),