chrome/test/chromedriver/chrome/stub_web_view.h - Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/stub_web_view.h

Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Working implementation of emulating network conditions with chromedriver Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/network_conditions_override_manager_unittest.cc ('K') | « chrome/test/chromedriver/chrome/network_conditions_override_manager_unittest.cc ('k') | chrome/test/chromedriver/chrome/stub_web_view.cc » ('j') | chrome/test/chromedriver/client/chromedriver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/stub_web_view.h

diff --git a/chrome/test/chromedriver/chrome/stub_web_view.h b/chrome/test/chromedriver/chrome/stub_web_view.h

index 0f59e6d6a7e1876f523db3b2e66a504c2a94de7a..4b23879e4e27b341f25ed656eeb42b2c86e35200 100644

--- a/chrome/test/chromedriver/chrome/stub_web_view.h

+++ b/chrome/test/chromedriver/chrome/stub_web_view.h

@@ -60,6 +60,8 @@ class StubWebView : public WebView {

bool* is_pending) override;

JavaScriptDialogManager* GetJavaScriptDialogManager() override;

Status OverrideGeolocation(const Geoposition& geoposition) override;

+ Status OverrideNetworkConditions(

+ const NetworkConditions& network_conditions) override;

Status CaptureScreenshot(std::string* screenshot) override;

Status SetFileInputFiles(const std::string& frame,

const base::DictionaryValue& element,