chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc - Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Working implementation of emulating network conditions with chromedriver Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/chrome/network_conditions.h » ('j') | chrome/test/chromedriver/chrome/network_conditions_override_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

index 099442f155df05216594c1ba47fbdbbbebbcbeac..1c5ee4bd98b7af5160b90deadee865a453b34a7d 100644

--- a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

+++ b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

@@ -54,7 +54,7 @@ class RecorderDevToolsClient : public StubDevToolsClient {

};

void AssertDeviceMetricsCommand(const Command& command,

- const DeviceMetrics& device_metrics) {

+ const DeviceMetrics& device_metrics) {

ASSERT_EQ("Page.setDeviceMetricsOverride", command.method);

int width, height;

double device_scale_factor, font_scale_factor;