Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 883083002: [chromedriver] Add Network Conditions Override Manager and tests (Closed)

Created:
5 years, 10 months ago by srawlins
Modified:
5 years, 9 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Network Conditions Override Manager and tests BUG=https://code.google.com/p/chromedriver/issues/detail?id=984 Committed: https://crrev.com/12a55ff7369b35adb29cd28f5e3dd4ef923e3e6c Cr-Commit-Position: refs/heads/master@{#319668}

Patch Set 1 #

Patch Set 2 : Working implementation of emulating network conditions with chromedriver #

Total comments: 10

Patch Set 3 : Addressing comments; mostly pulling RecorderDevToolsClient into its own class #

Patch Set 4 : Fixing scoping bug; switching throughput and latency fields to doubles #

Total comments: 3

Patch Set 5 : Adjusting OverrideNetworkConditions #

Patch Set 6 : Add a filtered-out offline test #

Total comments: 8

Patch Set 7 : nits #

Patch Set 8 : Fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -117 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc View 1 2 1 chunk +1 line, -43 lines 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc View 1 2 5 chunks +6 lines, -30 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc View 1 2 1 chunk +2 lines, -44 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_conditions.h View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_conditions_override_manager.h View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_conditions_override_manager.cc View 1 2 3 4 5 6 7 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_conditions_override_manager_unittest.cc View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/recorder_devtools_client.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/recorder_devtools_client.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/client/chromedriver.py View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/client/command_executor.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/session.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/session_commands.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 2 3 4 5 6 7 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/window_commands.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (8 generated)
srawlins
Hi Sam, I've got the basic override manager working (tested). While I'm working on the ...
5 years, 10 months ago (2015-01-28 19:51:52 UTC) #2
samuong
On 2015/01/28 19:51:52, srawlins wrote: > Hi Sam, I've got the basic override manager working ...
5 years, 10 months ago (2015-01-28 22:14:51 UTC) #3
srawlins
OK Sam, this is a working implementation. Qualifiers: * Offline is disabled. I'm filing a ...
5 years, 10 months ago (2015-02-05 20:10:07 UTC) #4
samuong
https://codereview.chromium.org/883083002/diff/20001/chrome/test/chromedriver/chrome/network_conditions_override_manager.h File chrome/test/chromedriver/chrome/network_conditions_override_manager.h (right): https://codereview.chromium.org/883083002/diff/20001/chrome/test/chromedriver/chrome/network_conditions_override_manager.h#newcode42 chrome/test/chromedriver/chrome/network_conditions_override_manager.h:42: scoped_ptr<NetworkConditions> overridden_network_conditions_; Does NetworkConditionsOverrideManager need to make/own a copy ...
5 years, 10 months ago (2015-02-11 23:22:14 UTC) #5
srawlins
OK I pulled RecorderDevToolsClient into its own shared class. Command is sitting at the top ...
5 years, 10 months ago (2015-02-25 22:40:57 UTC) #6
srawlins
Sorry, I introduced a scoping bug yesterday that wasn't caught with unit tests. I fixed ...
5 years, 10 months ago (2015-02-26 21:18:24 UTC) #7
samuong
Nice find with the scoping bug; I didn't notice that the first time I looked ...
5 years, 10 months ago (2015-02-26 23:07:44 UTC) #8
srawlins
https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc File chrome/test/chromedriver/chrome/network_conditions_override_manager.cc (right): https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode25 chrome/test/chromedriver/chrome/network_conditions_override_manager.cc:25: return ApplyOverrideIfNeeded(); On 2015/02/26 23:07:44, samuong wrote: > I ...
5 years, 9 months ago (2015-03-04 00:34:29 UTC) #9
samuong
https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc File chrome/test/chromedriver/chrome/network_conditions_override_manager.cc (right): https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode25 chrome/test/chromedriver/chrome/network_conditions_override_manager.cc:25: return ApplyOverrideIfNeeded(); On 2015/03/04 00:34:29, srawlins wrote: > On ...
5 years, 9 months ago (2015-03-04 06:37:58 UTC) #10
srawlins
On 2015/03/04 06:37:58, samuong wrote: > https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc > File chrome/test/chromedriver/chrome/network_conditions_override_manager.cc > (right): > > https://codereview.chromium.org/883083002/diff/60001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode25 ...
5 years, 9 months ago (2015-03-04 16:16:01 UTC) #11
srawlins
Added a filtered-out test for offline.
5 years, 9 months ago (2015-03-05 00:54:14 UTC) #12
samuong
lgtm with nits https://codereview.chromium.org/883083002/diff/100001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc File chrome/test/chromedriver/chrome/network_conditions_override_manager.cc (right): https://codereview.chromium.org/883083002/diff/100001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode27 chrome/test/chromedriver/chrome/network_conditions_override_manager.cc:27: nit: delete blank line https://codereview.chromium.org/883083002/diff/100001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode50 chrome/test/chromedriver/chrome/network_conditions_override_manager.cc:50: ...
5 years, 9 months ago (2015-03-05 23:43:21 UTC) #13
srawlins
https://codereview.chromium.org/883083002/diff/100001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc File chrome/test/chromedriver/chrome/network_conditions_override_manager.cc (right): https://codereview.chromium.org/883083002/diff/100001/chrome/test/chromedriver/chrome/network_conditions_override_manager.cc#newcode27 chrome/test/chromedriver/chrome/network_conditions_override_manager.cc:27: On 2015/03/05 23:43:20, samuong wrote: > nit: delete blank ...
5 years, 9 months ago (2015-03-05 23:50:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883083002/120001
5 years, 9 months ago (2015-03-05 23:53:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/33831)
5 years, 9 months ago (2015-03-06 02:42:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883083002/140001
5 years, 9 months ago (2015-03-07 00:36:05 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 02:37:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883083002/140001
5 years, 9 months ago (2015-03-09 16:44:29 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-03-09 17:30:52 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:31:29 UTC) #28
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/12a55ff7369b35adb29cd28f5e3dd4ef923e3e6c
Cr-Commit-Position: refs/heads/master@{#319668}

Powered by Google App Engine
This is Rietveld 408576698