src/preparser.h - Issue 883073008: Accessor functions should have no prototype property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 883073008: Accessor functions should have no prototype property (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use bitshift Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index 5be009d66a39c5227795067b53e183cf3dd268aa..29a2b55e83e89719ee6472c35f9826765adb5be6 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -2194,7 +2194,7 @@ ParserBase<Traits>::ParsePropertyDefinition(ObjectLiteralCheckerBase* checker,

typename Traits::Type::FunctionLiteral value = this->ParseFunctionLiteral(

name, scanner()->location(),

false, // reserved words are allowed here

- FunctionKind::kNormalFunction, RelocInfo::kNoPosition,

+ FunctionKind::kAccessorFunction, RelocInfo::kNoPosition,

FunctionLiteral::ANONYMOUS_EXPRESSION,

is_get ? FunctionLiteral::GETTER_ARITY : FunctionLiteral::SETTER_ARITY,

CHECK_OK_CUSTOM(EmptyObjectLiteralProperty));

« no previous file with comments | « src/ppc/full-codegen-ppc.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »