Accessor functions should have no prototype property

Accessor functions should have no prototype property

This also removes some convenience functions that were not used.

BUG=v8:3700
LOG=N
R=adamk@chromium.org, adamk

Committed: https://crrev.com/b67b3c54011351bde23656fc650a6398829851d8
Cr-Commit-Position: refs/heads/master@{#26472}

[arv (Not doing code reviews), 2015-02-05 22:16:31]

arv@chromium.org changed reviewers:
+ dslomov@chromium.org

[arv (Not doing code reviews), 2015-02-05 22:16:31]

PTAL

[arv (Not doing code reviews), 2015-02-05 22:18:07]

I was looking into v8:1984 and turned out I needed a flag for this to get that
working so I tackled this known issue as well.

[arv (Not doing code reviews), 2015-02-05 22:25:35]

fix assert

[arv (Not doing code reviews), 2015-02-05 22:51:22]

Fix assert again

[adamk, 2015-02-05 23:18:43]

lgtm % a few nits/questions

Might as well also mention removing the (mostly-unused, it seems) helper methods
in the CL description.

https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h
File src/code-stubs.h (left):

https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h#oldcode598
src/code-stubs.h:598: class FunctionKindBits : public BitField<FunctionKind, 2,
4> {};
Out of curiosity, was this just busted before?

https://codereview.chromium.org/883073008/diff/40001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/883073008/diff/40001/src/globals.h#newcode823
src/globals.h:823: kSubclassConstructor = 32
Maybe switch to shift-lefts now that this is getting big?

https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):

https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instruction...
src/hydrogen-instructions.h:7619: class FunctionKindField : public
BitField<FunctionKind, 0, 4> {};
Same question here?

[arv (Not doing code reviews), 2015-02-05 23:33:10]

New patchsets have been uploaded after l-g-t-m from adamk@chromium.org

[arv (Not doing code reviews), 2015-02-05 23:33:11]

Use bitshift

[arv (Not doing code reviews), 2015-02-05 23:34:01]

All done.

https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h
File src/code-stubs.h (left):

https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h#oldcode598
src/code-stubs.h:598: class FunctionKindBits : public BitField<FunctionKind, 2,
4> {};
On 2015/02/05 23:18:43, adamk wrote:
> Out of curiosity, was this just busted before?

Someone forgot to update it.

https://codereview.chromium.org/883073008/diff/40001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/883073008/diff/40001/src/globals.h#newcode823
src/globals.h:823: kSubclassConstructor = 32
On 2015/02/05 23:18:43, adamk wrote:
> Maybe switch to shift-lefts now that this is getting big?

Done.

https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):

https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instruction...
src/hydrogen-instructions.h:7619: class FunctionKindField : public
BitField<FunctionKind, 0, 4> {};
On 2015/02/05 23:18:43, adamk wrote:
> Same question here?

Same answer. The out sync bits was due to experimental classes which is off by
default and does not have a lot of test coverage yet.

[arv (Not doing code reviews), 2015-02-05 23:34:37]

Committed patchset #4 (id:60001) manually as
b67b3c54011351bde23656fc650a6398829851d8 (presubmit successful).

[commit-bot: I haz the power, 2015-02-05 23:34:41]

Patchset 4 (id:??) landed as
https://crrev.com/b67b3c54011351bde23656fc650a6398829851d8
Cr-Commit-Position: refs/heads/master@{#26472}

[adamk, 2015-02-05 23:35:00]

still lgtm