Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 883073006: Revert of Tweak output of (memcheck|drmemory)_analyze.py. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, earthdok
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tweak output of (memcheck|drmemory)_analyze.py. (patchset #1 id:1 of https://codereview.chromium.org/884813002/) Reason for revert: broke tree. don't use NOTRY=true again http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38252 Original issue's description: > Tweak output of (memcheck|drmemory)_analyze.py. > > Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us > to extract them with GTestLogParser and use them as snippets. > > BUG=453020 > R=thestig@chromium.org > NOTRY=true > > Committed: https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579 > Cr-Commit-Position: refs/heads/master@{#313572} TBR=thestig@chromium.org,earthdok@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453020 Committed: https://crrev.com/f9d331b6e4fbd446c3cb922565b89c7093b9c0a1 Cr-Commit-Position: refs/heads/master@{#313594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M tools/valgrind/drmemory_analyze.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/valgrind/memcheck_analyze.py View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Tweak output of (memcheck|drmemory)_analyze.py.
5 years, 10 months ago (2015-01-28 21:57:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883073006/1
5 years, 10 months ago (2015-01-28 21:58:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 21:59:23 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 22:02:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9d331b6e4fbd446c3cb922565b89c7093b9c0a1
Cr-Commit-Position: refs/heads/master@{#313594}

Powered by Google App Engine
This is Rietveld 408576698