Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 883073003: Mojo's network service should use a disk cache on Android (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo's network service should use a disk cache on Android Launching Mojo apps on Android is slow because we keep the network cache in memory, which means we lose it every time we launch MojoShell. After this CL, we use a disk cache on Android. Note: We still use a memory cache on desktop because we want to be able to run many instances of mojo_shell in parallel on desktop for testing. R=jamesr@chromium.org BUG=452226 Committed: https://crrev.com/d1cc658f889a6aeefed69ac49e56448c27e1df50 Cr-Commit-Position: refs/heads/master@{#313642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M mojo/services/network/network_context.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-01-28 19:29:48 UTC) #1
jamesr
We don't run tests in parallel on android?
5 years, 10 months ago (2015-01-28 19:30:57 UTC) #2
abarth-chromium
On 2015/01/28 at 19:30:57, jamesr wrote: > We don't run tests in parallel on android? ...
5 years, 10 months ago (2015-01-28 20:54:13 UTC) #3
jamesr
lgtm
5 years, 10 months ago (2015-01-28 23:44:41 UTC) #4
abarth-chromium
lgtm
5 years, 10 months ago (2015-01-28 23:55:59 UTC) #5
jamesr
On 2015/01/28 23:55:59, abarth wrote: > lgtm NO U
5 years, 10 months ago (2015-01-28 23:57:26 UTC) #6
abarth-chromium
On 2015/01/28 at 23:57:26, jamesr wrote: > On 2015/01/28 23:55:59, abarth wrote: > > lgtm ...
5 years, 10 months ago (2015-01-29 00:41:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883073003/1
5 years, 10 months ago (2015-01-29 00:42:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 00:45:54 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:46:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1cc658f889a6aeefed69ac49e56448c27e1df50
Cr-Commit-Position: refs/heads/master@{#313642}

Powered by Google App Engine
This is Rietveld 408576698