Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 883023003: Add UMA for startup load time of component extensions. At the moment there is (Closed)

Created:
5 years, 10 months ago by not at google - send to devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more fine grained UMA for ExtensionService initialization time. At the moment there is only total time and time to load all non-component extensions. Time to load component extensions and time to notify all listeners is not instrumented. R=mek@chromium.org, mpearson@chromium.org BUG=453073 Committed: https://crrev.com/fc4a9aaebb66e4f191bcd12f5d221a8e924c2c7a Cr-Commit-Position: refs/heads/master@{#313615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : more #

Total comments: 2

Patch Set 3 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M chrome/browser/extensions/component_loader.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
not at google - send to devlin
5 years, 10 months ago (2015-01-28 19:00:03 UTC) #1
Marijn Kruisselbrink
https://codereview.chromium.org/883023003/diff/1/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/883023003/diff/1/chrome/browser/extensions/component_loader.cc#newcode128 chrome/browser/extensions/component_loader.cc:128: base::Time start_time = base::Time::Now(); Shouldn't this be base::TimeTicks::Now() just ...
5 years, 10 months ago (2015-01-28 19:13:19 UTC) #2
Mark P
https://codereview.chromium.org/883023003/diff/1/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/883023003/diff/1/chrome/browser/extensions/component_loader.cc#newcode135 chrome/browser/extensions/component_loader.cc:135: base::TimeTicks::Now() - start_time); it probably would be better to ...
5 years, 10 months ago (2015-01-28 19:14:49 UTC) #3
not at google - send to devlin
copy paste fail. will fix in a sec.
5 years, 10 months ago (2015-01-28 19:29:00 UTC) #4
not at google - send to devlin
Fixed, and I decided to add a second UMA right below that one (in the ...
5 years, 10 months ago (2015-01-28 21:26:03 UTC) #6
not at google - send to devlin
with a BUG
5 years, 10 months ago (2015-01-28 21:26:08 UTC) #7
Mark P
histograms lgtm https://codereview.chromium.org/883023003/diff/40001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/883023003/diff/40001/chrome/browser/extensions/component_loader.cc#newcode129 chrome/browser/extensions/component_loader.cc:129: base::TimeTicks start_time = base::TimeTicks::Now(); nit: might as ...
5 years, 10 months ago (2015-01-28 21:30:12 UTC) #8
not at google - send to devlin
const'd
5 years, 10 months ago (2015-01-28 21:39:50 UTC) #9
Marijn Kruisselbrink
lgtm
5 years, 10 months ago (2015-01-28 21:52:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883023003/60001
5 years, 10 months ago (2015-01-28 21:55:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-01-28 23:30:51 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:32:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc4a9aaebb66e4f191bcd12f5d221a8e924c2c7a
Cr-Commit-Position: refs/heads/master@{#313615}

Powered by Google App Engine
This is Rietveld 408576698