Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 883013003: [Cast] Separate frame size from VideoSenderConfig in H264VideoToolboxEncoder. (Closed)

Created:
5 years, 10 months ago by miu
Modified:
5 years, 10 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast] Separate frame size from VideoSenderConfig in H264VideoToolboxEncoder. This is a prerequisite change for supporting variable video frame sizes in Cast. This allows a follow-up change to remove the width/height properties from VideoSenderConfig. Instead, the width/height is passed to the ctor in a separate gfx::Size argument. BUG=451277 Committed: https://crrev.com/a5cc14a27945deac78524ed75cf9b4d49cdec347 Cr-Commit-Position: refs/heads/master@{#313779}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M media/cast/sender/h264_vt_encoder.h View 2 chunks +7 lines, -4 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 4 chunks +17 lines, -9 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
miu
jfroy: PTAL.
5 years, 10 months ago (2015-01-28 22:04:16 UTC) #3
jfroy
LGTM
5 years, 10 months ago (2015-01-28 22:08:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883013003/20001
5 years, 10 months ago (2015-01-29 02:16:28 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-01-29 02:16:30 UTC) #8
miu
hubbe: Need you to rubber-stamp this, as a full committer.
5 years, 10 months ago (2015-01-29 02:33:54 UTC) #10
Alpha Left Google
RSLGTM.
5 years, 10 months ago (2015-01-29 19:55:52 UTC) #11
Alpha Left Google
On 2015/01/29 19:55:52, Alpha wrote: > RSLGTM. RS LGTM.
5 years, 10 months ago (2015-01-29 19:56:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883013003/20001
5 years, 10 months ago (2015-01-29 20:08:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-29 20:47:41 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:48:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5cc14a27945deac78524ed75cf9b4d49cdec347
Cr-Commit-Position: refs/heads/master@{#313779}

Powered by Google App Engine
This is Rietveld 408576698