Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883003005: Pepper: Fix PPB_TrueTypeFont GetFontsInFamily function. (Closed)

Created:
5 years, 10 months ago by bbudge
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: Fix PPB_TrueTypeFont GetFontsInFamily function. Function is incorrectly copying a std::wstring into a buffer. BUG=452886 Committed: https://crrev.com/5871c0e16696dda533f3a5461e7c27cada23a656 Cr-Commit-Position: refs/heads/master@{#313828}

Patch Set 1 #

Patch Set 2 : Use std::wstring::copy instead of memcpy. #

Patch Set 3 : Fix compile. #

Total comments: 2

Patch Set 4 : Leave room for null-terminator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
bbudge
5 years, 10 months ago (2015-01-29 22:11:23 UTC) #2
Lei Zhang
https://codereview.chromium.org/883003005/diff/40001/content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc File content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc (right): https://codereview.chromium.org/883003005/diff/40001/content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc#newcode79 content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc:79: family16.copy(logfont.lfFaceName, LF_FACESIZE); I believe the length argument should be ...
5 years, 10 months ago (2015-01-29 22:30:12 UTC) #3
bbudge
On 2015/01/29 22:30:12, Lei Zhang wrote: > https://codereview.chromium.org/883003005/diff/40001/content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc > File content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc > (right): > > ...
5 years, 10 months ago (2015-01-29 22:42:50 UTC) #4
Lei Zhang
lgtm, thanks for adding the comment.
5 years, 10 months ago (2015-01-29 22:44:55 UTC) #5
bbudge
https://codereview.chromium.org/883003005/diff/40001/content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc File content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc (right): https://codereview.chromium.org/883003005/diff/40001/content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc#newcode79 content/browser/renderer_host/pepper/pepper_truetype_font_list_win.cc:79: family16.copy(logfont.lfFaceName, LF_FACESIZE); On 2015/01/29 22:30:11, Lei Zhang wrote: > ...
5 years, 10 months ago (2015-01-29 22:45:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003005/60001
5 years, 10 months ago (2015-01-29 22:45:20 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-29 23:40:38 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 23:41:35 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5871c0e16696dda533f3a5461e7c27cada23a656
Cr-Commit-Position: refs/heads/master@{#313828}

Powered by Google App Engine
This is Rietveld 408576698