LayoutTests/media/track/track-selection-metadata.html - Issue 882993002: Implement automatic text track selection for 'metadata' tracks

Side by Side Diff: LayoutTests/media/track/track-selection-metadata.html

Issue 882993002: Implement automatic text track selection for 'metadata' tracks (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Multiple 'metadata' tracks with 'default'</title>

	3 <script src=../../resources/testharness.js></script>

	4 <script src=../../resources/testharnessreport.js></script>

	5 <video src="../content/test.ogv">

	6 <script>

	7 var test = async_test();

	8 var video = document.currentScript.parentNode;

	9 video.onloadstart = test.step_func(function() {
	philipj_slow 2015/01/29 10:34:52 To be less forgiving, do this immediately after </ To be less forgiving, do this immediately after </video> as that's the per-spec trigger for "honor user preferences for automatic text track selection". If you don't need a video.currentSrc for the test to pass, remove that. I does not seem required per spec. If you move it, you can also use the async_test(function(test) {}) pattern, which I like if there's nothing special going on. fs 2015/01/29 12:05:51 I've moved it. The selection is not run synchronou Show quoted text On 2015/01/29 10:34:52, philipj_UTC7 wrote: > To be less forgiving, do this immediately after </video> as that's the per-spec > trigger for "honor user preferences for automatic text track selection". If you > don't need a video.currentSrc for the test to pass, remove that. I does not seem > required per spec. I've moved it. The selection is not run synchronously at </video>, so it becomes a bit hard to observe it in a good and stable manner (hence the src). Quite possible that should be fixed... Show quoted text > If you move it, you can also use the async_test(function(test) {}) pattern, > which I like if there's nothing special going on. Done. philipj_slow 2015/01/29 14:58:04 Sounds like the automatic selection is triggered l Show quoted text On 2015/01/29 12:05:51, fs wrote: > On 2015/01/29 10:34:52, philipj_UTC7 wrote: > > To be less forgiving, do this immediately after </video> as that's the > per-spec > > trigger for "honor user preferences for automatic text track selection". If > you > > don't need a video.currentSrc for the test to pass, remove that. I does not > seem > > required per spec. > > I've moved it. The selection is not run synchronously at </video>, so it becomes > a bit hard to observe it in a good and stable manner (hence the src). Quite > possible that should be fixed... > > > If you move it, you can also use the async_test(function(test) {}) pattern, > > which I like if there's nothing special going on. > > Done. Sounds like the automatic selection is triggered later then required by the spec, then. fs 2015/01/29 15:06:51 Yes, this had me scratching my head for quite some Show quoted text On 2015/01/29 14:58:04, philipj_UTC7 wrote: > On 2015/01/29 12:05:51, fs wrote: > > On 2015/01/29 10:34:52, philipj_UTC7 wrote: > > > To be less forgiving, do this immediately after </video> as that's the > > per-spec > > > trigger for "honor user preferences for automatic text track selection". If > > you > > > don't need a video.currentSrc for the test to pass, remove that. I does not > > seem > > > required per spec. > > > > I've moved it. The selection is not run synchronously at </video>, so it > becomes > > a bit hard to observe it in a good and stable manner (hence the src). Quite > > possible that should be fixed... > > > > > If you move it, you can also use the async_test(function(test) {}) pattern, > > > which I like if there's nothing special going on. > > > > Done. > > Sounds like the automatic selection is triggered later then required by the > spec, then. Yes, this had me scratching my head for quite some time (I originally had a test() just after </video>.)
	10 var tracks = video.textTracks;

	11 assert_equals(tracks.length, 4);

	12 for (var i = 0; i < tracks.length; ++i) {

	13 assert_equals(tracks[i].kind, 'metadata');

	14

	15 var trackElement = document.getElementById(tracks[i].id);

	16 if (trackElement) {

	17 assert_true(trackElement.default);

	18 assert_equals(tracks[i].mode, 'hidden');

	19 } else {

	20 assert_equals(tracks[i].mode, 'disabled');
	philipj_slow 2015/01/29 10:34:52 Also assert_false(trackElement.default)? Also assert_false(trackElement.default)? fs 2015/01/29 12:05:51 That means I need to find the corresponding elemen Show quoted text On 2015/01/29 10:34:52, philipj_UTC7 wrote: > Also assert_false(trackElement.default)? That means I need to find the corresponding element in these cases too, which kind of jogs the test setup a bit. Done. philipj_slow 2015/01/29 14:58:04 Oh, I wasn't paying attention. It works the new wa Show quoted text On 2015/01/29 12:05:51, fs wrote: > On 2015/01/29 10:34:52, philipj_UTC7 wrote: > > Also assert_false(trackElement.default)? > > That means I need to find the corresponding element in these cases too, which > kind of jogs the test setup a bit. Done. Oh, I wasn't paying attention. It works the new way, though.
	21 }

	22 }

	23 test.done();

	24 });

	25 </script>

	26 <track kind="metadata" src="captions-webvtt/tc005-default-styles.vtt">

	27 <track kind="metadata" src="captions-webvtt/tc025-class.vtt" default id="hidde n1">

	28 <track kind="metadata" src="captions-webvtt/tc005-metadata-area.vtt">

	29 <track kind="metadata" src="captions-webvtt/tc004-webvtt-file.vtt" default id= "hidden2">

	30 </video>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')