Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 882983002: Add try release mode to test runner. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add try release mode to test runner. Also refactor the configuration of modes to have the level of abstraction in one json dict. In a follow up CL, the new mode could be added to quickcheck and release trybots. Committed: https://crrev.com/7a8d0c02a5e3e9996ebfdabfb953fd787e4dd3d2 Cr-Commit-Position: refs/heads/master@{#26322}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -19 lines) Patch
M tools/run-tests.py View 6 chunks +51 lines, -19 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/882983002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/882983002/diff/1/tools/run-tests.py#newcode119 tools/run-tests.py:119: "status_mode": "debug", Use debug as status mode as ...
5 years, 10 months ago (2015-01-28 14:10:05 UTC) #2
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-01-28 14:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882983002/1
5 years, 10 months ago (2015-01-29 09:53:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 10:23:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 10:23:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a8d0c02a5e3e9996ebfdabfb953fd787e4dd3d2
Cr-Commit-Position: refs/heads/master@{#26322}

Powered by Google App Engine
This is Rietveld 408576698