Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 882973006: Lint. (Closed)

Created:
5 years, 10 months ago by Bence
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lint. Driveby lint while working on https://crrev.com/665083009. * Remove redundant net:: namespace qualifiers. * Remove one redundant line. * Change probability literals from int to float. * Fix typos in comments. * Add https to one link in a comment. * git cl format to fix one indent and to reduce number of lines. BUG=392575 Committed: https://crrev.com/1102b557d0fc13866a67a11d570b740e5528fb4e Cr-Commit-Position: refs/heads/master@{#313971}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -71 lines) Patch
M net/http/http_network_transaction_unittest.cc View 8 chunks +14 lines, -15 lines 1 comment Download
M net/http/http_server_properties_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 17 chunks +22 lines, -35 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 10 months ago (2015-01-28 21:54:23 UTC) #2
Ryan Hamilton
LGTM But I'm not in love with the 1 -> 1.0 change. What's the motivation? ...
5 years, 10 months ago (2015-01-30 17:29:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882973006/1
5 years, 10 months ago (2015-01-30 19:14:35 UTC) #5
Bence
On 2015/01/30 17:29:15, Ryan Hamilton wrote: > LGTM > > But I'm not in love ...
5 years, 10 months ago (2015-01-30 19:16:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 20:11:36 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:12:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1102b557d0fc13866a67a11d570b740e5528fb4e
Cr-Commit-Position: refs/heads/master@{#313971}

Powered by Google App Engine
This is Rietveld 408576698