Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 882973003: Update SSL/malware/net error interstitial design (Closed)

Created:
5 years, 10 months ago by edwardjung
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SSL/malware/net error interstitial design + On small screens the navigation buttons are anchored to the bottom of the screen. + Tweaks to the text colour + Change button styling of safe browsing page BUG=422882 Committed: https://crrev.com/c2e35628285c2113775566cd85c52320e6fcf565 Cr-Commit-Position: refs/heads/master@{#313910}

Patch Set 1 #

Patch Set 2 : Update CrOS offline interstitial #

Patch Set 3 : Merge updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -107 lines) Patch
M chrome/browser/resources/chromeos/neterror.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_net_load.html View 1 2 2 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 10 chunks +369 lines, -12 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 2 1 chunk +22 lines, -17 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.js View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/resources/security_warnings/safe_browsing.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/neterror.css View 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 2 2 chunks +54 lines, -54 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 1 2 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
edwardjung
Erik, This is the same CL as https://codereview.chromium.org/865943002/ with addition of same updates to the ...
5 years, 10 months ago (2015-01-29 11:29:46 UTC) #2
arv (Not doing code reviews)
LGTM rubberstamp
5 years, 10 months ago (2015-01-29 17:14:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882973003/40001
5 years, 10 months ago (2015-01-30 13:13:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 14:00:07 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c2e35628285c2113775566cd85c52320e6fcf565 Cr-Commit-Position: refs/heads/master@{#313910}
5 years, 10 months ago (2015-01-30 14:02:02 UTC) #7
perkj_chrome
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/889983002/ by perkj@chromium.org. ...
5 years, 10 months ago (2015-01-30 16:14:54 UTC) #8
please use gerrit instead
5 years, 10 months ago (2015-01-30 16:15:19 UTC) #9
Message was sent while issue was closed.
Hi,

I think you broke browser_tests for error interstitials:

ErrorPageTest.DNSError_DoClickLink
ErrorPageTest.DNSError_DoReload

[ RUN      ] ErrorPageTest.DNSError_DoClickLink
[5878:5878:0130/062132:WARNING:chrome_browser_main_chromeos.cc(290)] Running as
stub user with profile dir: test-user
[5878:5878:0130/062132:INFO:audio_manager_pulse.cc(258)] Failed to connect to
the context.  Error: Connection refused
Xlib:  extension "RANDR" missing on display ":9".
[5878:5965:0130/062133:ERROR:owner_key_util_impl.cc(27)] Could not get size of
/tmp/.org.chromium.Chromium.RkEzjg/dDaGUHt/stub_owner.key
[5878:5965:0130/062133:WARNING:local_extension_cache.cc(199)] Extensions will
not be installed from update URLs until /var/cache/external_cache/.initialized
exists.
[5878:5878:0130/062133:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy
OFF at startup
[5878:5939:0130/062133:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup
freezer does not exist or is not writable. Unable to freeze renderer processes.
../../chrome/browser/errorpage_browsertest.cc:126: Failure
Value of: IsDisplayingText(browser, "http://correction1/")
  Actual: false
Expected: true
../../chrome/browser/errorpage_browsertest.cc:127: Failure
Value of: IsDisplayingText(browser, "http://correction2/")
  Actual: false
Expected: true
[  FAILED  ] ErrorPageTest.DNSError_DoClickLink, where TypeParam =  and
GetParam() =  (699 ms)

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Powered by Google App Engine
This is Rietveld 408576698