Fix android tests.

Fix android tests.

TBR=ncbray@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/4422851b44f52ed64fb6c0b51d191f3ea23a64ee

[qsr, 2015-01-28 16:20:46]

Committed patchset #1 (id:1) manually as
4422851b44f52ed64fb6c0b51d191f3ea23a64ee (presubmit successful).

[qsr, 2015-01-28 16:22:45]

https://codereview.chromium.org/882953003/diff/1/shell/shell_test_base.cc
File shell/shell_test_base.cc (right):

https://codereview.chromium.org/882953003/diff/1/shell/shell_test_base.cc#new...
shell/shell_test_base.cc:28: SetUpTestApplications();
The issue there is that Init is calling SetBaseURL, so the changes in
SetUpTestApplications were not taken into account.

I'm not sure it is such a good idea that Init will erase some pre configuration,
but if this is the intention, then calling anything on the context that might be
overridden should CHECK(false).

[Nick Bray (chromium), 2015-01-28 21:46:13]

Retroactive LGTM.  Subtle and interesting.  I think that the best fix would be
to remove all the command line interpretation from context.cc, and use the
command line to drive the configuration Context object from the outside.  This
would mesh better with Android and unit testing.

[qsr, 2015-01-30 15:31:53]

On 2015/01/28 21:46:13, Nick Bray (chromium) wrote:
> Retroactive LGTM.  Subtle and interesting.  I think that the best fix would be
> to remove all the command line interpretation from context.cc, and use the
> command line to drive the configuration Context object from the outside.  This
> would mesh better with Android and unit testing.

 I agree. But this would have to be in a helper function that can be used by
both the linux and android entry points.