Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 882913006: Make functions contexts in optimized code weak. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make functions contexts in optimized code weak. BUG= Committed: https://crrev.com/f0511a8d802974404a7827ecb73e4e295e034889 Cr-Commit-Position: refs/heads/master@{#26436}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/lithium.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL https://codereview.chromium.org/882913006/diff/1/src/lithium.cc File src/lithium.cc (right): https://codereview.chromium.org/882913006/diff/1/src/lithium.cc#newcode430 src/lithium.cc:430: ZoneList<Handle<HeapObject> > objects(1, zone()); Changes here just remove ...
5 years, 10 months ago (2015-02-03 16:15:49 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 10 months ago (2015-02-04 15:51:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882913006/20001
5 years, 10 months ago (2015-02-04 15:55:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 17:13:56 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 17:14:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0511a8d802974404a7827ecb73e4e295e034889
Cr-Commit-Position: refs/heads/master@{#26436}

Powered by Google App Engine
This is Rietveld 408576698