Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: testing/test_env.py

Issue 882913004: test_env.py: Disable sandbox on clang/win for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: indent Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index 3ff56dc120a722e6699b0f4934962ed99c49f04b..5f94326a9d198edd2cadc49e74e996931732f201 100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -126,6 +126,9 @@ def run_executable(cmd, env):
if asan:
extra_env.update(get_asan_env(cmd, lsan))
+ # ASan is not yet sandbox-friendly on Windows (http://crbug.com/382867).
+ if sys.platform == 'win32':
+ cmd.append('--no-sandbox')
if lsan:
cmd.append('--no-sandbox')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698