test_env.py: Disable sandbox on clang/win for now.

test_env.py: Disable sandbox on clang/win for now.

Swarming uses the command baked into the isolate (via test_env.py) for running
test instead of using the runtest.py script.  Hence, test_env.py needs to
learn everything runtest.py already knows -- for example, that tests can't
run with the sandbox in asan/win yet.

BUG=451741, 382867
TBR=scottmg@chromium.org

Committed: https://crrev.com/bfeb3d3af47c2f4f0a7f8e1b39d516e31bbb9df7
Cr-Commit-Position: refs/heads/master@{#313452}

[Nico, 2015-01-28 06:15:08]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2015-01-28 06:15:09]

Small follow-up to the CL earlier today (the one that added sys.executable).

[Nico, 2015-01-28 06:15:12]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-28 06:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/882913004/1

[Nico, 2015-01-28 06:18:33]

Committed patchset #2 (id:20001) to pending queue manually as
5dd896db60827306e428ab161b96b3937275f2fa (presubmit successful).

[commit-bot: I haz the power, 2015-01-28 06:18:40]

Patchset 2 (id:??) landed as
https://crrev.com/bfeb3d3af47c2f4f0a7f8e1b39d516e31bbb9df7
Cr-Commit-Position: refs/heads/master@{#313452}

[scottmg, 2015-01-28 17:31:54]

lgtm

(allegedly sys.platform.startswith() is "the way" these days
https://docs.python.org/2/library/sys.html#sys.platform )

[Nico, 2015-01-28 17:35:54]

On Wed, Jan 28, 2015 at 9:31 AM, <scottmg@chromium.org> wrote:

> lgtm
>
> (allegedly sys.platform.startswith() is "the way" these days
> https://docs.python.org/2/library/sys.html#sys.platform )
>

That's for linux only though, right?

(lols at the "In Python 3.3 and later, the value will always be set to
'linux', so it is recommended to always use the startswith idiom presented
above." bit. One would think they learned their lesson.)

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2015-01-28 17:44:25]

Yeah, you're right. I had some vague recollection that maybe someday
"win" might be non-32, but it looks like that isn't scheduled until Python
4!

On Wed, Jan 28, 2015 at 9:35 AM, Nico Weber <thakis@chromium.org> wrote:

> On Wed, Jan 28, 2015 at 9:31 AM, <scottmg@chromium.org> wrote:
>
>> lgtm
>>
>> (allegedly sys.platform.startswith() is "the way" these days
>> https://docs.python.org/2/library/sys.html#sys.platform )
>>
>
> That's for linux only though, right?
>
> (lols at the "In Python 3.3 and later, the value will always be set to
> 'linux', so it is recommended to always use the startswith idiom presented
> above." bit. One would think they learned their lesson.)
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Timur Iskhodzhanov, 2015-01-28 18:41:44]

Python 4?  You've got to be kidding %)

On Wed Jan 28 2015 at 8:44:25 PM Scott Graham <scottmg@chromium.org> wrote:

> Yeah, you're right. I had some vague recollection that maybe someday
> "win" might be non-32, but it looks like that isn't scheduled until Python
> 4!
>
> On Wed, Jan 28, 2015 at 9:35 AM, Nico Weber <thakis@chromium.org> wrote:
>
>> On Wed, Jan 28, 2015 at 9:31 AM, <scottmg@chromium.org> wrote:
>>
>>> lgtm
>>>
>>> (allegedly sys.platform.startswith() is "the way" these days
>>> https://docs.python.org/2/library/sys.html#sys.platform )
>>>
>>
>> That's for linux only though, right?
>>
>> (lols at the "In Python 3.3 and later, the value will always be set to
>> 'linux', so it is recommended to always use the startswith idiom presented
>> above." bit. One would think they learned their lesson.)
>>
>  To unsubscribe from this group and stop receiving emails from it, send an
>> email to chromium-reviews+unsubscribe@chromium.org.
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2015-01-28 18:52:50]

 Yes, kidding :)

From what I can tell from reading HN, we should have Strong AI before we
switch to Python 3, so hopefully Python 4 won't cause us any trouble. ;)


On Wed, Jan 28, 2015 at 10:41 AM, Timur Iskhodzhanov <timurrrr@chromium.org>
wrote:

> Python 4?  You've got to be kidding %)
>
> On Wed Jan 28 2015 at 8:44:25 PM Scott Graham <scottmg@chromium.org>
> wrote:
>
>> Yeah, you're right. I had some vague recollection that maybe someday
>> "win" might be non-32, but it looks like that isn't scheduled until Python
>> 4!
>>
>> On Wed, Jan 28, 2015 at 9:35 AM, Nico Weber <thakis@chromium.org> wrote:
>>
>>> On Wed, Jan 28, 2015 at 9:31 AM, <scottmg@chromium.org> wrote:
>>>
>>>> lgtm
>>>>
>>>> (allegedly sys.platform.startswith() is "the way" these days
>>>> https://docs.python.org/2/library/sys.html#sys.platform )
>>>>
>>>
>>> That's for linux only though, right?
>>>
>>> (lols at the "In Python 3.3 and later, the value will always be set to
>>> 'linux', so it is recommended to always use the startswith idiom presented
>>> above." bit. One would think they learned their lesson.)
>>>
>>  To unsubscribe from this group and stop receiving emails from it, send
>>> an email to chromium-reviews+unsubscribe@chromium.org.
>>>
>>
>>  To unsubscribe from this group and stop receiving emails from it, send
> an email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.