Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 882913002: Run V8 GC before detecting Document leaks in inspector_memory_unittest.py. (Closed)

Created:
5 years, 10 months ago by Yuta Kitamura
Modified:
5 years, 10 months ago
Reviewers:
kouhei (in TOK), marja
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run V8 GC before detecting Document leaks in inspector_memory_unittest.py. Previously, this unit test was consistently failing because DOM wrappers were retained at the time of detecting Document leaks. This patch adds a call to V8's gc() before the leak check to make sure the DOM wrappers are freed. BUG=422244 R=kouhei@chromium.org Committed: https://crrev.com/2c9ef53fe11f7b108b5cd58b5486aae710cdfafe Cr-Commit-Position: refs/heads/master@{#313471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory_unittest.py View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Yuta Kitamura
5 years, 10 months ago (2015-01-28 03:07:14 UTC) #1
kouhei (in TOK)
+marja: Would you do a OWNER review? lgtm
5 years, 10 months ago (2015-01-28 03:10:00 UTC) #3
Yuta Kitamura
FYI: The test has passed on Linux. > [103/762] telemetry.core.backends.chrome_inspector.inspector_memory_unittest.InspectorMemoryTest.testGetDOMStats passed
5 years, 10 months ago (2015-01-28 03:54:19 UTC) #4
marja
rubberstamp lgtm
5 years, 10 months ago (2015-01-28 09:46:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882913002/1
5 years, 10 months ago (2015-01-28 10:04:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 10:09:06 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 10:11:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c9ef53fe11f7b108b5cd58b5486aae710cdfafe
Cr-Commit-Position: refs/heads/master@{#313471}

Powered by Google App Engine
This is Rietveld 408576698