Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 882883007: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Torne
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=torne@chromium.org Committed: https://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6 Cr-Commit-Position: refs/heads/master@{#314606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M android_webview/browser/renderer_host/aw_render_view_host_ext.h View 2 chunks +7 lines, -8 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 3 chunks +16 lines, -18 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/renderer_host/print_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:45:41 UTC) #1
Torne
lgtm
5 years, 10 months ago (2015-02-04 12:28:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882883007/1
5 years, 10 months ago (2015-02-04 18:38:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 19:19:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:20:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6
Cr-Commit-Position: refs/heads/master@{#314606}

Powered by Google App Engine
This is Rietveld 408576698