Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 882883006: Remove Client= relationship in omnibox.mojom (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, arv+watch_chromium.org, darin (slow to review), James Su, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Client= relationship in omnibox.mojom omnibox.mojom defines the following interface for javascript to request omnibox suggestions from C++ code: interface OmniboxUIHandlerMojo { StartOmniboxQuery(string input_string, int32 cursor_position, bool prevent_inline_autocomplete, bool prefer_keyword, int32 page_classification); }; and the corresponding API for sending results back: interface OmniboxPage { HandleNewAutocompleteResult(OmniboxResultMojo result); }; These were defined as clients of each other so they shared a message pipe. However, there was no way for the caller of StartOmniboxQuery() to correlate calls to HandleNewAutocompleteResult() with a particular invocation of StartOmniboxQuery(). Additionally we're getting rid of the Client= notion in mojom. This changes the StartOmniboxQuery API to take an additional parameter of type OmniboxPage corresponding to a new message pipe that can receive requests. The caller in omnibox.js allocates a new pipe for each query (closing the previous one) and gets replies on the new pipe. (this is a potential use case of a multiple return value syntax in mojom but that's just a proposal right now). R=sky@chromium.org BUG=451321 Committed: https://crrev.com/59ca1ee57ad1224e31a1449a6dc80796bd7b08f5 Cr-Commit-Position: refs/heads/master@{#314592}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M chrome/browser/resources/omnibox/omnibox.js View 4 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
5 years, 10 months ago (2015-02-04 00:59:30 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-04 18:05:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882883006/20001
5 years, 10 months ago (2015-02-04 18:33:40 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 18:41:53 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:43:56 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59ca1ee57ad1224e31a1449a6dc80796bd7b08f5
Cr-Commit-Position: refs/heads/master@{#314592}

Powered by Google App Engine
This is Rietveld 408576698