Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 882883004: Don't forward frames that can't be converted to I420. (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't forward frames that can't be converted to I420. This patch change VideoCaptureController to ignore buffers that cant be converted to I420. This is mostly important for failures in MJPG decoding. BUG=453761 Committed: https://crrev.com/e63cb64457a53eaaf4aa6637f0a7e1847ebea109 Cr-Commit-Position: refs/heads/master@{#314548}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M content/browser/renderer_host/media/video_capture_controller.cc View 1 1 chunk +22 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_chrome
I found the MJPG problem. Can you please review? It can happen on all platforms.
5 years, 10 months ago (2015-02-03 20:42:52 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 10 months ago (2015-02-04 11:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882883004/20001
5 years, 10 months ago (2015-02-04 11:51:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 12:40:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 12:42:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e63cb64457a53eaaf4aa6637f0a7e1847ebea109
Cr-Commit-Position: refs/heads/master@{#314548}

Powered by Google App Engine
This is Rietveld 408576698