Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 882883003: Revert of Hairline batch (Closed)

Created:
5 years, 10 months ago by joshualitt
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@2_defer
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Hairline batch (patchset #17 id:360001 of https://codereview.chromium.org/876673002/) Reason for revert: still a performance regression Original issue's description: > Hairline batch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6eff8701f027016fbb3147412ec2292dcec2b7f5 > > Committed: https://skia.googlesource.com/skia/+/658d55cd6121c67488aaf5d0832c9712737f26a5 TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/46c77f76be8cbcddccc1ae0058d589cbbdb468f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -505 lines) Patch
M src/gpu/GrAAHairLinePathRenderer.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 9 chunks +277 lines, -466 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrBatch.h View 3 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 7 chunks +5 lines, -13 lines 0 comments Download
M src/gpu/GrBatchTarget.cpp View 1 chunk +11 lines, -14 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Hairline batch
5 years, 10 months ago (2015-02-03 16:39:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882883003/1
5 years, 10 months ago (2015-02-03 16:40:14 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:40:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/46c77f76be8cbcddccc1ae0058d589cbbdb468f7

Powered by Google App Engine
This is Rietveld 408576698