chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 882873002: Close the permission bubble when use clicks 'esc'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 882873002: Close the permission bubble when use clicks 'esc' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index ae41cd192260805c8770cae7808eec212559e821..c2ec5c1688b0da19508f1567cbd1e7701f3d0457 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -226,7 +226,7 @@ PermissionsBubbleDelegateView::PermissionsBubbleDelegateView(

RemoveAllChildViews(true);

customize_comboboxes_.clear();

- set_close_on_esc(false);

+ set_close_on_esc(true);

set_close_on_deactivate(false);

SetLayoutManager(new views::BoxLayout(

« no previous file with comments | « no previous file | no next file » | no next file with comments »