Issue 882853006: Revert of rename SkCanvasDrawable to SkDrawable, and make public

Issue 882853006: Revert of rename SkCanvasDrawable to SkDrawable, and make public (Closed)

Created:
5 years, 10 months ago by reed1

Modified:
5 years, 10 months ago

Reviewers:
djsollen, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/) Reason for revert: bug in gyp Original issue's description: > rename SkCanvasDrawable to SkDrawable, and make public > > BUG=skia: > NOTRY=True > ... winbuilder flake > > Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6 TBR=robertphillips@google.com,djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c4e87724920222a218f31b22612efc5b1ec0ed6c

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+207 lines, -221 lines)			Patch
M	gyp/core.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/core/SkCanvas.h	View	3 chunks	+3 lines, -11 lines	0 comments	Download
D	include/core/SkDrawable.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
M	include/core/SkPictureRecorder.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleArc.cpp	View	6 chunks	+7 lines, -6 lines	0 comments	Download
M	samplecode/SampleHT.cpp	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	src/core/SkCanvasDrawable.h	View	1 chunk	+69 lines, -0 lines	0 comments	Download
A	src/core/SkCanvasDrawable.cpp	View	1 chunk	+77 lines, -0 lines	0 comments	Download
D	src/core/SkDrawable.cpp	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	src/core/SkPictureRecorder.cpp	View	7 chunks	+17 lines, -17 lines	0 comments	Download
M	src/core/SkRecordDraw.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkRecordDraw.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkRecorder.h	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	src/core/SkRecorder.cpp	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/core/SkRecords.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of rename SkCanvasDrawable to SkDrawable, and make public

5 years, 10 months ago (2015-02-06 16:19:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882853006/1

5 years, 10 months ago (2015-02-06 16:19:55 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 16:20:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c4e87724920222a218f31b22612efc5b1ec0ed6c