Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 882833002: Fix variable shadowing warning in CRLSet on VS2015 (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-udp_socket
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing warning in CRLSet on VS2015 d:\src\cr3\src\net\cert\crl_set.cc(53): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\net\cert\crl_set.cc(53): warning C4456: declaration of 'i' hides previous local declaration d:\src\cr3\src\net\cert\crl_set.cc(47): note: see declaration of 'i' R=mattm@chromium.org BUG=440500 Committed: https://crrev.com/61da3cc6e760e2b93126df78081838cd74a95fb8 Cr-Commit-Position: refs/heads/master@{#313410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/cert/crl_set.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 10 months ago (2015-01-27 22:32:18 UTC) #2
mattm
lgtm
5 years, 10 months ago (2015-01-27 23:53:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882833002/1
5 years, 10 months ago (2015-01-27 23:59:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 00:03:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 00:04:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61da3cc6e760e2b93126df78081838cd74a95fb8
Cr-Commit-Position: refs/heads/master@{#313410}

Powered by Google App Engine
This is Rietveld 408576698