|
|
Created:
5 years, 10 months ago by edwardjung Modified:
5 years ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReformat offline summary message on mobile.
BUG=452727
Committed: https://crrev.com/9c62bac72db560386caf8eac30e783dd63bcb0cd
Cr-Commit-Position: refs/heads/master@{#314261}
Patch Set 1 #
Messages
Total messages: 25 (10 generated)
edwardjung@chromium.org changed reviewers: + bettes@chromium.org
Alan, double check the change is good.
On 2015/01/29 14:54:37, edwardjung wrote: > Alan, double check the change is good. From what I can tell, I *think* that looks right, lol.
On 2015/01/29 19:15:28, bettes wrote: > On 2015/01/29 14:54:37, edwardjung wrote: > > Alan, double check the change is good. > > From what I can tell, I *think* that looks right, lol. Can you LGTM it. Ta!
On 2015/01/29 19:48:31, edwardjung wrote: > On 2015/01/29 19:15:28, bettes wrote: > > On 2015/01/29 14:54:37, edwardjung wrote: > > > Alan, double check the change is good. > > > > From what I can tell, I *think* that looks right, lol. > > Can you LGTM it. Ta! I'm sorry, I'm not familiar with this format. LGTM here? LGTM!!
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813006/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813006/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
edwardjung@chromium.org changed reviewers: + cpu@chromium.org
@cpu, please take a look. Thanks.
lgtm
The CQ bit was checked by cpu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9c62bac72db560386caf8eac30e783dd63bcb0cd Cr-Commit-Position: refs/heads/master@{#314261}
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |