base/metrics/histogram.cc - Issue 882783002: Add missing .Pass() on return of SampleVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram.cc

Issue 882783002: Add missing .Pass() on return of SampleVector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2015-histogram

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram.cc

diff --git a/base/metrics/histogram.cc b/base/metrics/histogram.cc

index 3b8ef86e232a3f6c20998f86bfb1eb70b963189b..42ced3d0abc2d366d7c077c349d5ff91c00f64fe 100644

--- a/base/metrics/histogram.cc

+++ b/base/metrics/histogram.cc

@@ -369,7 +369,7 @@ HistogramBase* Histogram::DeserializeInfoImpl(PickleIterator* iter) {

scoped_ptr<SampleVector> Histogram::SnapshotSampleVector() const {

scoped_ptr<SampleVector> samples(new SampleVector(bucket_ranges()));

samples->Add(*samples_);

- return samples;

+ return samples.Pass();

}

void Histogram::WriteAsciiImpl(bool graph_it,

« no previous file with comments | « no previous file | no next file » | no next file with comments »