Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 882743003: Fix pedantic build warnings; (Closed)

Created:
5 years, 11 months ago by JF
Modified:
5 years, 11 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix pedantic build warnings; GCC 4.8.1 is sad; There are extra semicolons in Subzero; It removes the semicolons or it gets the build warning hose again;^H R=stichnot@chromium.org BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8427ea2b5b3e165130377ab4aca836ed65afcae4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/IceTLS.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/IceTypes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
JF
5 years, 11 months ago (2015-01-27 19:46:20 UTC) #1
Jim Stichnoth
lgtm
5 years, 11 months ago (2015-01-27 20:55:59 UTC) #2
JF
5 years, 11 months ago (2015-01-27 20:56:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8427ea2b5b3e165130377ab4aca836ed65afcae4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698