Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 882733003: Fix variable shadowing warnings in UDPSocketWin on VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-peimage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing warnings in UDPSocketWin on VS2015 d:\src\cr3\src\net\udp\udp_socket_win.cc(330): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\net\udp\udp_socket_win.cc(330): warning C4457: declaration of 'address' hides function parameter d:\src\cr3\src\net\udp\udp_socket_win.cc(319): note: see declaration of 'address' d:\src\cr3\src\net\udp\udp_socket_win.cc(351): warning C4457: declaration of 'address' hides function parameter d:\src\cr3\src\net\udp\udp_socket_win.cc(340): note: see declaration of 'address' R=eroman@chromium.org BUG=440500 Committed: https://crrev.com/3a1c346e8d17824ec8732333ac167206c5dad322 Cr-Commit-Position: refs/heads/master@{#313390}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/udp/udp_socket_win.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 11 months ago (2015-01-27 21:17:03 UTC) #2
eroman
lgtm
5 years, 11 months ago (2015-01-27 21:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882733003/20001
5 years, 11 months ago (2015-01-27 21:58:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 22:57:59 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:58:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a1c346e8d17824ec8732333ac167206c5dad322
Cr-Commit-Position: refs/heads/master@{#313390}

Powered by Google App Engine
This is Rietveld 408576698