Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.h

Issue 882723003: Make it possible to navigate <iframes> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/html/HTMLIFrameElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.h
diff --git a/sky/engine/core/html/HTMLIFrameElement.h b/sky/engine/core/html/HTMLIFrameElement.h
index a95654c2c6f8675df5c942cd9b38fffd60a81c26..4759212bc6c88a01d5456c1d53e7cc67bc7c3fa3 100644
--- a/sky/engine/core/html/HTMLIFrameElement.h
+++ b/sky/engine/core/html/HTMLIFrameElement.h
@@ -22,29 +22,32 @@ class HTMLIFrameElement : public HTMLElement,
public:
static PassRefPtr<HTMLIFrameElement> create(Document&);
- virtual ~HTMLIFrameElement();
+ ~HTMLIFrameElement() override;
mojo::View* contentView() const { return m_contentView; }
- ScriptValue takeServiceProvider(ScriptState*);
+ ScriptValue takeServicesHandle(ScriptState*);
+ ScriptValue takeExposedServicesHandle(ScriptState*);
private:
explicit HTMLIFrameElement(Document&);
// HTMLElement methods:
- virtual RenderObject* createRenderer(RenderStyle* style) override;
+ RenderObject* createRenderer(RenderStyle* style) override;
- virtual void insertedInto(ContainerNode*) override;
- virtual void removedFrom(ContainerNode*) override;
+ void insertedInto(ContainerNode*) override;
+ void removedFrom(ContainerNode*) override;
+ void parseAttribute(const QualifiedName& name, const AtomicString& value) override;
// ViewObserver methods:
void OnViewDestroyed(mojo::View* view) override;
-private:
void createView();
+ void navigateView();
mojo::View* m_contentView;
mojo::ServiceProviderPtr m_services;
+ mojo::ScopedMessagePipeHandle m_exposedServices;
};
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/core/html/HTMLIFrameElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698