Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 882713002: Update Valgrind's run_chrome_tests.py to pass sharding flags. (Closed)

Created:
5 years, 11 months ago by earthdok
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Valgrind's run_chrome_tests.py to pass sharding flags. Previously we relied on environment variables. This unbreaks Valgrind following a recent CL which changed runtest.py to pass those flags. BUG=none TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/c93ebf902eaa453be47a30243065b75cea73ddf2 Cr-Commit-Position: refs/heads/master@{#313289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/valgrind/chrome_tests.py View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
5 years, 11 months ago (2015-01-27 16:48:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882713002/1
5 years, 11 months ago (2015-01-27 16:49:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 16:50:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c93ebf902eaa453be47a30243065b75cea73ddf2 Cr-Commit-Position: refs/heads/master@{#313289}
5 years, 11 months ago (2015-01-27 16:51:45 UTC) #5
Lei Zhang
5 years, 11 months ago (2015-01-27 19:33:10 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698