chrome/browser/extensions/crx_installer.cc - Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: id Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | chrome/browser/extensions/extension_chrome_auth_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 3530d61d931c261535939593ffba046fac400caf..c7a900b97f8990116088d4c0d75b7487d3c2d328 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -391,8 +391,8 @@ void CrxInstaller::ConfirmInstall() {

GURL overlapping_url;

const Extension* overlapping_extension =

- frontend_weak_->

- GetExtensionByOverlappingWebExtent(extension_->web_extent());

+ frontend_weak_->extensions()->

+ GetHostedAppByOverlappingWebExtent(extension_->web_extent());

if (overlapping_extension &&

overlapping_extension->id() != extension_->id()) {

ReportFailureFromUIThread(l10n_util::GetStringFUTF8(