chrome/browser/chromeos/login/help_app_launcher.cc - Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/help_app_launcher.cc

Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: :memory Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/chromeos/offline/offline_load_page.cc » ('j') | chrome/browser/extensions/extension_navigation_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/help_app_launcher.cc

diff --git a/chrome/browser/chromeos/login/help_app_launcher.cc b/chrome/browser/chromeos/login/help_app_launcher.cc

index b3c95a7bdf6bbbfa10442f4b2e298e82224a2a12..5675b0bb1463f808aa17f73dbc919f83bb835272 100644

--- a/chrome/browser/chromeos/login/help_app_launcher.cc

+++ b/chrome/browser/chromeos/login/help_app_launcher.cc

@@ -46,7 +46,7 @@ void HelpAppLauncher::ShowHelpTopic(HelpTopic help_topic_id) {

static_cast<int>(help_topic_id)));

// HelpApp component extension presents only in official builds so we can

// show help only when the extensions is installed.

- if (service->GetExtensionByURL(url))

+ if (service->extensions()->GetByURL(ExtensionURLInfo(url)))

ShowHelpTopicDialog(GURL(url));

}