ui/gfx/render_text.h - Issue 882643005: Add multiline support to RenderTextHarfBuzz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text.h

Issue 882643005: Add multiline support to RenderTextHarfBuzz. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text.h

diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h

index 415132ff0b22e5a63672a8b9ee1f70b025a2d23b..b38c350bc3b927313088421e709f4cfff7a6e119 100644

--- a/ui/gfx/render_text.h

+++ b/ui/gfx/render_text.h

@@ -580,6 +580,7 @@ class GFX_EXPORT RenderText {

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_NormalWidth);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_SufficientWidth);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_Newline);

+ FRIEND_TEST_ALL_PREFIXES(RenderTextTest, NewlineWithoutMultilineFlag);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, GlyphBounds);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_GlyphBounds);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest,

« no previous file with comments | « no previous file | ui/gfx/render_text_harfbuzz.h » ('j') | ui/gfx/render_text_harfbuzz.h » ('J')