Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 882633002: Reland "Only use FreeSpace objects in the free list" (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Only use FreeSpace objects in the free list" Committed: https://crrev.com/e5a082f0c4b74d2bb6722b481c229ab0f3983af9 Cr-Commit-Position: refs/heads/master@{#26296}

Patch Set 1 #

Patch Set 2 : fix gcc 4.8 build. #

Patch Set 3 : silence tsan #

Patch Set 4 : correctly repair free list #

Patch Set 5 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -311 lines) Patch
M src/allocation-tracker.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/api.cc View 3 chunks +51 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 chunks +17 lines, -11 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +14 lines, -55 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 17 chunks +48 lines, -158 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 3 chunks +12 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +33 lines, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +27 lines, -15 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 6 chunks +32 lines, -19 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
Please take a look. Patch sets 2 and 3 are fixes.
5 years, 11 months ago (2015-01-27 09:58:20 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 11 months ago (2015-01-27 11:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882633002/60001
5 years, 11 months ago (2015-01-27 13:48:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1449)
5 years, 11 months ago (2015-01-27 14:07:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882633002/80001
5 years, 11 months ago (2015-01-27 14:27:01 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-27 14:56:57 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 14:57:10 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e5a082f0c4b74d2bb6722b481c229ab0f3983af9
Cr-Commit-Position: refs/heads/master@{#26296}

Powered by Google App Engine
This is Rietveld 408576698