Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 882583002: Add a scrollbar to sky-scrollable (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a scrollbar to sky-scrollable Ideally the scrollbar would animate out when you stop scrolling, but we're not quite that good yet. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c9516ee0334fa0e7f5ddc59768a62e5f315a32f5

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M sky/framework/sky-scrollable.sky View 2 chunks +36 lines, -9 lines 5 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-27 05:24:36 UTC) #1
ojan
lgtm https://codereview.chromium.org/882583002/diff/1/sky/framework/sky-scrollable.sky File sky/framework/sky-scrollable.sky (right): https://codereview.chromium.org/882583002/diff/1/sky/framework/sky-scrollable.sky#newcode61 sky/framework/sky-scrollable.sky:61: // TODO(abarth): Can we get these values without ...
5 years, 11 months ago (2015-01-27 05:32:25 UTC) #2
abarth-chromium
https://codereview.chromium.org/882583002/diff/1/sky/framework/sky-scrollable.sky File sky/framework/sky-scrollable.sky (right): https://codereview.chromium.org/882583002/diff/1/sky/framework/sky-scrollable.sky#newcode61 sky/framework/sky-scrollable.sky:61: // TODO(abarth): Can we get these values without forcing ...
5 years, 11 months ago (2015-01-27 05:36:39 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-27 05:37:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9516ee0334fa0e7f5ddc59768a62e5f315a32f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698