Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 882543002: Add ChannelPosix::ResetSafely() to deal with a lingering crash (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 11 months ago
Reviewers:
agl, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ChannelPosix::ResetSafely() to deal with a lingering crash The CL [1] tightened the error check too much and revealed an existing inconsistency and resulted a production crash. This CL makes a workaround to that crash, turning a PCHECK() to DPCHECK(). This is the second attempt. The first one was reverted at [2] [1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4 [2] https://crrev.com/b83c03c7b691914a054abaab13fb9131b4e0152b BUG=449233, 448245 R=agl@chromium.org,jam@chromium.org Committed: https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca Cr-Commit-Position: refs/heads/master@{#313188} Committed: https://crrev.com/2ad0be41e3029cfc6c1c5a8068d6d0873aa3871c Cr-Commit-Position: refs/heads/master@{#313334}

Patch Set 1 #

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M ipc/ipc_channel_posix.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 4 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
Hajime Morrita
5 years, 11 months ago (2015-01-27 00:04:59 UTC) #1
agl
LGTM for addressing the crash, although it would be nice to address the existing issue ...
5 years, 11 months ago (2015-01-27 00:38:39 UTC) #2
Hajime Morrita
On 2015/01/27 00:38:39, agl wrote: > LGTM for addressing the crash, although it would be ...
5 years, 11 months ago (2015-01-27 01:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882543002/1
5 years, 11 months ago (2015-01-27 01:15:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 01:20:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca Cr-Commit-Position: refs/heads/master@{#313188}
5 years, 11 months ago (2015-01-27 01:21:32 UTC) #7
yoichio
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/878843002/ by yoichio@chromium.org. ...
5 years, 11 months ago (2015-01-27 04:15:05 UTC) #8
Hajime Morrita
DCHECK() has a side effect :-( Having a fix, will land soon.
5 years, 11 months ago (2015-01-27 18:58:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882543002/20001
5 years, 11 months ago (2015-01-27 19:02:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 20:06:23 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:07:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ad0be41e3029cfc6c1c5a8068d6d0873aa3871c
Cr-Commit-Position: refs/heads/master@{#313334}

Powered by Google App Engine
This is Rietveld 408576698