Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 882483006: Revert "Roll libvpx: cc9c0c:8dc6ea" (Closed)

Created:
5 years, 11 months ago by dconnelly
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, yoichio
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll libvpx: cc9c0c:8dc6ea" This reverts commit efd856c2a46810e742f7aba0130d534783db6b2a. Fails on Windows (e.g. http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/52878) BUG= NOTRY=true Committed: https://crrev.com/6d999751820c23a2ab6aaaa1747cf1d51db0cd85 Cr-Commit-Position: refs/heads/master@{#313258}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add more dummy lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M DEPS View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
dconnelly
5 years, 11 months ago (2015-01-27 11:49:40 UTC) #2
dconnelly
5 years, 11 months ago (2015-01-27 11:50:32 UTC) #3
Michael Achenbach
lgtm https://codereview.chromium.org/882483006/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/882483006/diff/1/DEPS#newcode46 DEPS:46: 'libvpx_revision': 'cc9c0c5198e416173f480fb1f11e052f5c29a95b', nit: You'll need the three lines ...
5 years, 11 months ago (2015-01-27 11:51:16 UTC) #4
dconnelly
https://codereview.chromium.org/882483006/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/882483006/diff/1/DEPS#newcode46 DEPS:46: 'libvpx_revision': 'cc9c0c5198e416173f480fb1f11e052f5c29a95b', On 2015/01/27 11:51:15, Michael Achenbach wrote: > ...
5 years, 11 months ago (2015-01-27 11:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882483006/20001
5 years, 11 months ago (2015-01-27 11:54:10 UTC) #7
Michael Achenbach
lgtm
5 years, 11 months ago (2015-01-27 11:54:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882483006/20001
5 years, 11 months ago (2015-01-27 11:55:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 11:56:16 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6d999751820c23a2ab6aaaa1747cf1d51db0cd85 Cr-Commit-Position: refs/heads/master@{#313258}
5 years, 11 months ago (2015-01-27 11:57:22 UTC) #13
Johann
5 years, 11 months ago (2015-01-27 16:36:36 UTC) #14
Message was sent while issue was closed.
Ugh, I specifically re-disabled AVX2 because of the Windows issues for exactly
this reason:
https://codereview.chromium.org/880513003/

Will take another look.

Powered by Google App Engine
This is Rietveld 408576698