Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2600)

Unified Diff: ui/app_list/search/mixer_unittest.cc

Issue 882463004: app_list: Refactor mixer groups to avoid hard-coded groups in Mixer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@applist-mixer-clamp
Patch Set: Rewrite comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/search/mixer_unittest.cc
diff --git a/ui/app_list/search/mixer_unittest.cc b/ui/app_list/search/mixer_unittest.cc
index 78c233eec1ef9f367dff3062959064e9fd94dcee..250c517da2482464de56eef59bc6f87443fd5916 100644
--- a/ui/app_list/search/mixer_unittest.cc
+++ b/ui/app_list/search/mixer_unittest.cc
@@ -19,6 +19,12 @@
namespace app_list {
namespace test {
+// Maximum number of results to show in each mixer group.
+const size_t kMaxAppsGroupResults = 4;
+const size_t kMaxOmniboxResults = 0; // Unlimited.
+const size_t kMaxWebstoreResults = 2;
+const size_t kMaxPeopleResults = 2;
+
class TestSearchResult : public SearchResult {
public:
TestSearchResult(const std::string& id, double relevance)
@@ -111,11 +117,17 @@ class MixerTest : public testing::Test {
is_voice_query_ = false;
mixer_.reset(new Mixer(results_.get()));
- mixer_->Init();
- mixer_->AddProviderToGroup(Mixer::MAIN_GROUP, providers_[0]);
- mixer_->AddProviderToGroup(Mixer::OMNIBOX_GROUP, providers_[1]);
- mixer_->AddProviderToGroup(Mixer::WEBSTORE_GROUP, providers_[2]);
- mixer_->AddProviderToGroup(Mixer::PEOPLE_GROUP, providers_[3]);
+
+ size_t apps_group_id = mixer_->AddGroup(kMaxAppsGroupResults, 3.0);
+ size_t omnibox_group_id = mixer_->AddGroup(kMaxOmniboxResults, 2.0);
+ size_t webstore_group_id = mixer_->AddGroup(kMaxWebstoreResults, 1.0);
+ size_t people_group_id = mixer_->AddGroup(kMaxPeopleResults, 0.0);
+ DCHECK_EQ(omnibox_group_id, Mixer::OMNIBOX_GROUP);
+
+ mixer_->AddProviderToGroup(apps_group_id, providers_[0]);
+ mixer_->AddProviderToGroup(omnibox_group_id, providers_[1]);
+ mixer_->AddProviderToGroup(webstore_group_id, providers_[2]);
+ mixer_->AddProviderToGroup(people_group_id, providers_[3]);
}
void RunQuery() {

Powered by Google App Engine
This is Rietveld 408576698