app_list: Refactor mixer groups to avoid hard-coded groups in Mixer.

ui/app_list/search/mixer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/search/mixer.h"
 
 #include <algorithm>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "ui/app_list/search_provider.h"
 #include "ui/app_list/search_result.h"
 
 namespace app_list {
 
 namespace {
 
 // Maximum number of results to show.
 const size_t kMaxResults = 6;
-const size_t kMaxMainGroupResults = 4;
-const size_t kMaxWebstoreResults = 2;
-const size_t kMaxPeopleResults = 2;
-const size_t kMaxSuggestionsResults = 6;
 
 // A value to indicate no max number of results limit.
 const size_t kNoMaxResultsLimit = 0;
 
 void UpdateResult(const SearchResult& source, SearchResult* target) {
   target->set_display_type(source.display_type());
   target->set_title(source.title());
   target->set_title_tags(source.title_tags());
   target->set_details(source.details());
   target->set_details_tags(source.details_tags());
 }
 
 }  // namespace
 
+const size_t Mixer::OMNIBOX_GROUP = 1;
+
 Mixer::SortData::SortData() : result(NULL), score(0.0) {
 }
 
 Mixer::SortData::SortData(SearchResult* result, double score)
     : result(result), score(score) {
 }
 
 bool Mixer::SortData::operator<(const SortData& other) const {
   // This data precedes (less than) |other| if it has higher score.
   return score > other.score;
@@ skipping 68 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(Group);
 };
 
 Mixer::Mixer(AppListModel::SearchResults* ui_results)
     : ui_results_(ui_results) {
 }
 Mixer::~Mixer() {
 }
 
-void Mixer::Init() {
-  groups_[MAIN_GROUP].reset(new Group(kMaxMainGroupResults, 3.0));
-  groups_[OMNIBOX_GROUP].reset(new Group(kNoMaxResultsLimit, 2.0));
-  groups_[WEBSTORE_GROUP].reset(new Group(kMaxWebstoreResults, 1.0));
-  groups_[PEOPLE_GROUP].reset(new Group(kMaxPeopleResults, 0.0));
-  groups_[SUGGESTIONS_GROUP].reset(new Group(kMaxSuggestionsResults, 3.0));
+size_t Mixer::AddGroup(size_t max_results, double boost) {
+  groups_.push_back(new Group(max_results, boost));
+  return groups_.size() - 1;
 }
 
-void Mixer::AddProviderToGroup(GroupId group, SearchProvider* provider) {
-  groups_[group]->AddProvider(provider);
+void Mixer::AddProviderToGroup(size_t group_id, SearchProvider* provider) {
+  groups_[group_id]->AddProvider(provider);
 }
 
 void Mixer::MixAndPublish(bool is_voice_query,
                           const KnownResults& known_results) {
   FetchResults(is_voice_query, known_results);
 
   SortedResults results;
   results.reserve(kMaxResults);
 
-  const Group& main_group = *groups_[MAIN_GROUP];
-  const Group& omnibox_group = *groups_[OMNIBOX_GROUP];
-  const Group& webstore_group = *groups_[WEBSTORE_GROUP];
-  const Group& people_group = *groups_[PEOPLE_GROUP];
-  const Group& suggestions_group = *groups_[SUGGESTIONS_GROUP];
-
-  // Adds main group and web store results first.
-  results.insert(results.end(), main_group.results().begin(),
-                 main_group.results().end());
-  results.insert(results.end(), webstore_group.results().begin(),
-                 webstore_group.results().end());
-  results.insert(results.end(), people_group.results().begin(),
-                 people_group.results().end());
-  results.insert(results.end(), suggestions_group.results().begin(),
-                 suggestions_group.results().end());
+  // Add results from non-omnibox groups first.
+  for (size_t i = 0; i < groups_.size(); ++i) {
+    if (i != OMNIBOX_GROUP) {
+      const Group& group = *groups_[i];
+      results.insert(results.end(), group.results().begin(),
+                     group.results().end());
+    }
+  }
 
   // Collapse duplicate apps from local and web store.
   RemoveDuplicates(&results);
 
   // Fill the remaining slots with omnibox results. Always add at least one
   // omnibox result (even if there are no more slots; if we over-fill the
   // vector, the web store and people results will be removed in a later step).
+  CHECK_LT(OMNIBOX_GROUP, groups_.size());
+  const Group& omnibox_group = *groups_[OMNIBOX_GROUP];
   const size_t omnibox_results =
       std::min(omnibox_group.results().size(),
                results.size() < kMaxResults ? kMaxResults - results.size() : 1);
   results.insert(results.end(), omnibox_group.results().begin(),
                  omnibox_group.results().begin() + omnibox_results);
 
   std::sort(results.begin(), results.end());
   RemoveDuplicates(&results);
   if (results.size() > kMaxResults)
     results.resize(kMaxResults);
@@ skipping 63 matching lines @@
 
     id_set.insert(id);
     final.push_back(sort_data);
   }
 
   results->swap(final);
 }
 
 void Mixer::FetchResults(bool is_voice_query,
                          const KnownResults& known_results) {
-  for (const auto& item : groups_)
-    item.second->FetchResults(is_voice_query, known_results);
+  for (auto* group : groups_)
+    group->FetchResults(is_voice_query, known_results);
 }
 
 }  // namespace app_list