Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 882443004: Revert of Only use FreeSpace objects in the free list. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Only use FreeSpace objects in the free list. (patchset #3 id:40001 of https://codereview.chromium.org/876613002/) Reason for revert: Test failures Original issue's description: > Only use FreeSpace objects in the free list. > > This solves an issue with the custom startup snapshot, in cases where > deserializing the isolate requires more than one page per space. > > R=hpayer@chromium.org > > Committed: https://crrev.com/66964395108f03220cb6f45ddc73c5965e2c76a9 > Cr-Commit-Position: refs/heads/master@{#26285} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cc79418b598615bc00ebbbe81acb50a1da56ae8f Cr-Commit-Position: refs/heads/master@{#26287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -261 lines) Patch
M src/allocation-tracker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/api.cc View 3 chunks +0 lines, -51 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +58 lines, -17 lines 0 comments Download
M src/heap/spaces.cc View 17 chunks +158 lines, -38 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 3 chunks +6 lines, -12 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -33 lines 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +16 lines, -28 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 7 chunks +19 lines, -58 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Only use FreeSpace objects in the free list.
5 years, 10 months ago (2015-01-27 09:40:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882443004/1
5 years, 10 months ago (2015-01-27 09:41:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 09:41:14 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 09:41:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc79418b598615bc00ebbbe81acb50a1da56ae8f
Cr-Commit-Position: refs/heads/master@{#26287}

Powered by Google App Engine
This is Rietveld 408576698